Update antimalware.py to be more consistent with other information messages & improve code a slight bit#671
Merged
Conversation
added 3 commits
November 25, 2019 15:21
…ssages (like the codeblock reminder) & improve code a slight bit
Akarys42
suggested changes
Nov 25, 2019
Contributor
Akarys42
left a comment
Akarys42
left a comment
There was a problem hiding this comment.
Looks pretty good, just two small things
avayert
suggested changes
Nov 25, 2019
…/except block and implement the changes requested by Ava
Author
|
All requested tweaks have been made :) |
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I looked at the
antimalware.pyand felt like I could improve a bit, and I hope I've accomplished that. I look forward to your review of this pull request! 😁Here's a list of differences that has been made:
on_messagecan ever returnNotFound. If I'm wrong, I'm more than happy to add that back in.I think this is an overall improvement to the message and code itself, and I hope you guys agree 😁